Skip to content

Conversation

@AndreasTu
Copy link
Member

This shall ensure the execution with JUnit 6 is possible.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.07%. Comparing base (a29c310) to head (e64e180).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2236   +/-   ##
=========================================
  Coverage     82.07%   82.07%           
  Complexity     4756     4756           
=========================================
  Files           465      465           
  Lines         14872    14872           
  Branches       1877     1877           
=========================================
  Hits          12206    12206           
  Misses         1978     1978           
  Partials        688      688           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

Vampire commented Oct 22, 2025

Wouldn't it instead make sense to have a second test task in spock-specs that runs with JUnit 6 so that all tests are executed? There could also be problems in specific paths, like when using data driven tests and so on.

@AndreasTu
Copy link
Member Author

We could do that, but I did not want to double the test-execution time.
I would be more specific, if there is a regression add a test for JUnit6 there instead of executing everything twice.

Copy link
Member

Vampire commented Oct 22, 2025

@leonard84 what's your take on this? :-)

@leonard84
Copy link
Member

If we want to test the SpockEngine compatibility, then I'd reuse spock-testkit.

@AndreasTu
Copy link
Member Author

@leonard84 done

This shall ensure the execution with JUnit 6 is possible.
@AndreasTu AndreasTu changed the title Add junit6-integration test project Add junit6 to spock-testkit Oct 28, 2025
@AndreasTu AndreasTu requested a review from leonard84 November 2, 2025 14:58
@leonard84 leonard84 enabled auto-merge (squash) November 8, 2025 15:16
@leonard84 leonard84 merged commit 4338a84 into spockframework:master Nov 8, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants