Feature/tippi 795 repo maintainance #324
Merged
+5,797
−9,943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d replaced npm with yarn
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repository's technical foundation by upgrading to Node.js 24, introducing TypeScript support, and establishing comprehensive linting with ESLint and SonarCloud integration. The changes also migrate from npm to yarn and add the secure flag to test cookie settings.
Key Changes:
- Upgraded Node.js to version 24 and migrated package manager from npm to yarn
- Introduced TypeScript configuration with ts-jest and comprehensive type definitions
- Replaced legacy ESLint configuration with modern flat config including TypeScript and stylistic rules
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated Node.js to v24, migrated to yarn, added TypeScript and updated dependencies |
| eslint.config.js | New flat ESLint configuration with TypeScript, import, and stylistic plugins |
| .eslintrc.js | Removed legacy ESLint configuration file |
| tests/cmp/cmp_custom_vendor_mapping.test.js | Added secure flag to test cookie assignments |
| tests/brandstory/brsndstory_scrolldepth.test.js | Added secure flag to test cookie assignments |
| backup/doPlugins/bild.js | Added secure flag to cookie setting in backup file |
| backup/doPlugins/bild-bild.js | Added secure flag to cookie setting in backup file |
| backup/cmp_custom_vendor_mapping/welt.js | Added secure flag to cookie deletion in backup file |
| README.md | Updated documentation to use yarn instead of npm |
| .sonarcloud.properties | Added SonarCloud configuration for code analysis |
| .github/workflows/feature.yml | Updated CI workflow to use Node 24, yarn, and newer action versions |
| .github/pull_request_template.md | Added standardized PR template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
LyubovSugak
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Setup NodeJs 24
Setup TypeScript
Setup EsLint and SonarCloud
Why?
We want to maintain this repository and therefor we want to improve the technical foundation
Link to supporting ticket or Screenshots (if applicable)
https://axelspringer.atlassian.net/browse/TIPPI-795