-
Notifications
You must be signed in to change notification settings - Fork 2k
Create MongoDB chat memory implementation #2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2d88035 to
76752cf
Compare
.../springframework/ai/model/chat/memory/mongodb/autoconfigure/MongoDbChatMemoryProperties.java
Outdated
Show resolved
Hide resolved
...mory-mongodb/src/main/java/org/springframework/ai/chat/memory/mongodb/MongoDbChatMemory.java
Show resolved
Hide resolved
...pringframework/ai/model/chat/memory/mongodb/autoconfigure/MongoDbChatMemoryIndexCreator.java
Outdated
Show resolved
Hide resolved
...db/src/test/java/org/springframework/ai/chat/memory/mongodb/MongoDbChatMemoryConfigTest.java
Outdated
Show resolved
Hide resolved
...db/src/test/java/org/springframework/ai/chat/memory/mongodb/MongoDbChatMemoryConfigTest.java
Show resolved
Hide resolved
...ongodb/src/test/java/org/springframework/ai/chat/memory/mongodb/MongoDbChatMemoryTestIT.java
Outdated
Show resolved
Hide resolved
8321e4d to
14375f0
Compare
290cacf to
78ad992
Compare
|
I feel like it could be better to have only Mongo instead of MongoDb in all classes names. It would follow the same logic as all classes in org.springframework.data.mongodb (MongoTemplate and not MongoDbTemplate) |
...-configurations/models/chat/memory/spring-ai-autoconfigure-model-chat-memory-mongodb/pom.xml
Outdated
Show resolved
Hide resolved
249380d to
e483254
Compare
Good idea to keep it in sync. Implemented |
e483254 to
44d84c2
Compare
|
This will probably be reimplemented tomorrow atop of #2803 |
|
@deejay1 thanks so much for your contribution! We have just delivered some changes to the Upgrade Notes: https://docs.spring.io/spring-ai/reference/upgrade-notes.html#_chat_memory |
|
@ThomasVitale sure, I'll rewrite it of course! |
f3d3324 to
73ea405
Compare
|
@ThomasVitale ok, rewritten into a ChatMemoryRepository implementation |
68c5cfc to
71e7584
Compare
|
@ThomasVitale any chances to get it in before 1.0.0? |
a5081dd to
451790f
Compare
ebde7fa to
d662788
Compare
9275fb9 to
dd5f08b
Compare
|
@ilayaperumalg any chances this also gets merged? we're using it successfully in prod for a while now (since April to be exact ;) |
55f7519 to
74a39de
Compare
74a39de to
0223d3d
Compare
|
This is great and would help a ton - any chance to get this in soon? @markpollack |
memory/repository/spring-ai-model-chat-memory-repository-mongodb/pom.xml
Outdated
Show resolved
Hide resolved
...st/java/org/springframework/ai/chat/memory/repository/mongo/MongoChatMemoryRepositoryIT.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/ai/chat/memory/repository/mongo/MongoChatMemoryRepository.java
Outdated
Show resolved
Hide resolved
...-mongodb/src/main/java/org/springframework/ai/chat/memory/repository/mongo/Conversation.java
Outdated
Show resolved
Hide resolved
.../ai/model/chat/memory/repository/mongo/autoconfigure/MongoChatMemoryAutoConfigurationIT.java
Outdated
Show resolved
Hide resolved
...rk/ai/model/chat/memory/repository/mongo/autoconfigure/MongoChatMemoryAutoConfiguration.java
Outdated
Show resolved
Hide resolved
0223d3d to
6421723
Compare
Signed-off-by: Łukasz Jernaś <lukasz.jernas@allegro.com>
6421723 to
0f19710
Compare
|
@deejay1 It seems like you write the metadata information, but doesn't seem to restore it upon read. Is that intentional? Also how about throwing an |
This is the initial implementation of a stock MongoDB chat memory which doesn't require MongoDB Atlas
Closes #2688