fix MCP Server Lazy initialisation issue #4069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue occurred because MCP server beans (McpSyncServer/McpAsyncServer) were not being created when Spring Boot lazy initialization was enabled. This caused: - Missing tool registration logs - Null sessionFactory in transport providers - NPE when accessing MCP endpoints (/sse, /mcp/message) Changes: - Added @lazy(false) to McpSyncServer and McpAsyncServer beans to force eager initialization - Added comprehensive tests for lazy initialization compatibility - Verified existing functionality remains unchanged The fix ensures MCP servers work correctly regardless of lazy initialization settings, maintaining backward compatibility while resolving the reported issue. Signed-off-by: Mattia Pasetto <matpat17@gmail.com>
|
Related to #4671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4055
I believe the issue occurs because MCP server beans aren't created when Spring Boot lazy initialization is enabled, causing NPE when accessing MCP
endpoints.
Changes
@Lazy(false)to force eager initialization of MCP server beansThis seems to resolve the reported issue while maintaining existing functionality.
Test plan
3 files were modified:
Signed-off-by: Mattia Pasetto matpat17@gmail.com
I am still pretty new to contributions, please double check and let me know of any errors.