Skip to content

Conversation

@ericbottard
Copy link
Member

I'm tired of running maven only to realize format is broken.

This PR instead runs the format earlier in the lifecycle. I've used this successfully on other Spring projects.

Now, this has a shortcoming: what if people don't run maven locally before submitting their PR / or before us merging it?
Well, the formatting may differ and become stale, until it gets fixed again with the next well behaved PR.
I still believe this is better than the current frustrating situation.

If you disagree, we can come up with a more advanced setup where CI runs check and developers run apply automatically, having the best of both worlds. Let me know.

Signed-off-by: Eric Bottard <eric.bottard@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant