-
Notifications
You must be signed in to change notification settings - Fork 41.9k
NoSuchMethodException when forcing the use of Log4J2LoggingSystem using org.springframework.boot.logging.LoggingSystem system property #49343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FBibonne
wants to merge
8
commits into
spring-projects:main
Choose a base branch
from
FBibonne:fix-Log4J2-forced
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−11
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fe8fc8d
test: failing test log4j2 can be forced
FBibonne 4551f16
log4j2 can be forced
FBibonne e2215b3
refactor: formatting issues
FBibonne da03b94
test: check that LoggingSystem can be forced
FBibonne d83f1bc
refactor: Log4J2LoggingSystem constructor and factory
FBibonne 325393b
refactor: make Log4J2LoggingSystem single parameter constructor packa…
FBibonne f6360af
refactor: remove constructor Log4J2LoggingSystem.<init>(ClassLoader, …
FBibonne 7a7a758
refactor: change tests after constructor Log4J2LoggingSystem.<init>(C…
FBibonne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,6 +116,7 @@ void cleanUp() { | |
| this.loggingSystem.getConfiguration().stop(); | ||
| this.loggingSystem.cleanUp(); | ||
| PluginRegistry.getInstance().clear(); | ||
| LogManager.getFactory().removeContext(this.loggingSystem.getLoggerContext()); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this necessary? |
||
| } | ||
|
|
||
| @Test | ||
|
|
@@ -127,7 +128,7 @@ void noFile(CapturedOutput output) { | |
| Configuration configuration = this.loggingSystem.getConfiguration(); | ||
| assertThat(output).contains("Hello world").doesNotContain("Hidden"); | ||
| assertThat(new File(tmpDir() + "/spring.log")).doesNotExist(); | ||
| assertThat(configuration.getConfigurationSource().getFile()).isNotNull(); | ||
| assertThat(configuration.getConfigurationSource().getLocation()).contains("log4j2-test.xml"); | ||
|
Comment on lines
-130
to
+131
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change appears to be unrelated. Please revert |
||
| } | ||
|
|
||
| @Test | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these changes add much, particular not the part that's describing what the code does. We generally reserve comments for situations where we need to describe why something is the way it is. The code itself describes the what. Please revert. This will leave this constructor more closely aligned with the other logging system constructors.