-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for XDELEX and XACKDEL, and expand options for XADD and XTRIM #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
viktoriya-kutsarova
wants to merge
6
commits into
spring-projects:main
from
viktoriya-kutsarova:topic/introduce-xdelex-xackdel-and-expand-xadd-xtrim
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Oct 24, 2025
b604a71 to
e108b24
Compare
e108b24 to
cb6b9f7
Compare
Closes spring-projects#3232 Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com> # Conflicts: # src/main/java/org/springframework/data/redis/connection/ReactiveStreamCommands.java # src/main/java/org/springframework/data/redis/connection/jedis/JedisClusterStreamCommands.java # src/main/java/org/springframework/data/redis/connection/lettuce/LettuceReactiveStreamCommands.java # src/main/java/org/springframework/data/redis/core/ReactiveStreamOperations.java # src/test/java/org/springframework/data/redis/connection/jedis/StreamConvertersUnitTest.java # Conflicts: # Makefile
Closes spring-projects#3232 Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
…options Signed-off-by: Chris Bono <chris.bono@broadcom.com>
391f7bc to
47c7ce2
Compare
Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
47c7ce2 to
4135f26
Compare
Contributor
|
Great work @viktoriya-kutsarova ! Thank you for the contribution. Closing in favor of ab12ddd |
onobc
added a commit
that referenced
this pull request
Dec 8, 2025
This commit performs the following polishing changes: - remove manual not null check in `TrimOptions.<init>` as it's already `@NullMarked` - annotate `RedisStreamCommands.XDelOptions` with `@NullMarked` - remove usage of `var` in main code - use since `4.1` instead of `4.0` - rename pendingReferences to deletionPolicy - use ParameterizedTest for StreamConvertersUnitTest - simplify test to not verify things it does not do - fix formatting in various classes - minor tweak to javadocs - inline converters in Lettuce StreamConverters Original pull request #3247 See #3232 Signed-off-by: Chris Bono <chris.bono@broadcom.com>
onobc
added a commit
that referenced
this pull request
Dec 8, 2025
Moves trim options into top-level class that is used by XTrim and Xdd options. Original pull request #3247 See #3232 Co-authored-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com> Signed-off-by: Chris Bono <chris.bono@broadcom.com> Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
onobc
added a commit
that referenced
this pull request
Dec 8, 2025
This commit performs the following polishing changes: - remove manual not null check in `TrimOptions.<init>` as it's already `@NullMarked` - annotate `RedisStreamCommands.XDelOptions` with `@NullMarked` - remove usage of `var` in main code - use since `4.1` instead of `4.0` - rename pendingReferences to deletionPolicy - use ParameterizedTest for StreamConvertersUnitTest - simplify test to not verify things it does not do - fix formatting in various classes - minor tweak to javadocs - inline converters in Lettuce StreamConverters Original pull request #3247 See #3232 Signed-off-by: Chris Bono <chris.bono@broadcom.com>
onobc
added a commit
that referenced
this pull request
Dec 8, 2025
Groups the integration tests in DefaultStreamOperationsIntegrationTests for XACKDEL and XDELEX and adds an `@EnabledOnCommand` guard to each test group to prevent them from being run in environments that do not support these commands (e.g. Valkey). Original pull request #3247 See #3232 Signed-off-by: Chris Bono <chris.bono@broadcom.com>
onobc
added a commit
that referenced
this pull request
Dec 8, 2025
Moves trim options into top-level class that is used by XTrim and Xdd options. Original pull request #3247 See #3232 Co-authored-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com> Signed-off-by: Chris Bono <chris.bono@broadcom.com> Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
onobc
added a commit
that referenced
this pull request
Dec 8, 2025
This commit performs the following polishing changes: - remove manual not null check in `TrimOptions.<init>` as it's already `@NullMarked` - annotate `RedisStreamCommands.XDelOptions` with `@NullMarked` - remove usage of `var` in main code - use since `4.1` instead of `4.0` - rename pendingReferences to deletionPolicy - use ParameterizedTest for StreamConvertersUnitTest - simplify test to not verify things it does not do - fix formatting in various classes - minor tweak to javadocs - inline converters in Lettuce StreamConverters Original pull request #3247 See #3232 Signed-off-by: Chris Bono <chris.bono@broadcom.com>
onobc
added a commit
that referenced
this pull request
Dec 8, 2025
Groups the integration tests in DefaultStreamOperationsIntegrationTests for XACKDEL and XDELEX and adds an `@EnabledOnCommand` guard to each test group to prevent them from being run in environments that do not support these commands (e.g. Valkey). Original pull request #3247 See #3232 Signed-off-by: Chris Bono <chris.bono@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the Support XDELEX, XACKEX and extend XADD and XTRIM options feature as part of the features provided by the spring-data-redis project. Closes #3232.
As part of the change the following commands would be made available:
As part of the change the following command options would be made available for XADD and XTRIM:
The new commands are available as part of the following interfaces:
This feature is available starting from Redis OSS version 8.2.x and later
Closes #3232