Fix EXPLAIN AST formatting for ShowCreateTableQuery, DetachQuery, and AttachQuery #72
+193
−1,091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AttachQuery - Add extra space before table name in ShowCreateTableQuery (single table case) - Add Identifier child output for DetachQuery when table is specified (two spaces) - Add Identifier child output for AttachQuery when table is specified (one space) - Pass SystemQuery to explainSystemQuery for future extensibility These formatting fixes match ClickHouse's EXPLAIN AST output format, fixing 897 explain test statements (64 unique test directories).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These formatting fixes match ClickHouse's EXPLAIN AST output format, fixing
897 explain test statements (64 unique test directories).