Conversation
japplin
left a comment
japplin
left a comment
There was a problem hiding this comment.
The zoom behaviour and locking of content to the bounds of the window feels much better now as does the double to click to zoom. The scroll wheel zooming is buggy and honestly I don't think needed at all given how well double click to zoom works.
| scope.launch { | ||
| // TODO: this doesn't work super well. | ||
| // Probably because of https://github.com/saket/telephoto/issues/135? | ||
| zoomableState.zoomTo( |
There was a problem hiding this comment.
From local testing this isn't adjusting the pan at all when selecting a node.
There was a problem hiding this comment.
This should be fixed by saket/telephoto@68fcaef. Do you mind if I update telephoto to its latest snapshot version?
| Box( | ||
| modifier = modifier.onSizeChanged { | ||
| appWindowSize = it | ||
| // TODO: do we want to draw behind the search bar? |
There was a problem hiding this comment.
I think drawing behind the search looks correct, which is what it's doing already, if we didn't allow it there would be a jarring cutoff.
There was a problem hiding this comment.
In that case, do you want to synchronize the content padding below with the search box's height?
There was a problem hiding this comment.
I'm not sure, I think it was looking good how it was now.
|
|
||
| val focusRequester = remember { FocusRequester() } | ||
| LaunchedEffect(zoomableState) { | ||
| // Request focus to receive keyboard shortcuts. |
There was a problem hiding this comment.
This is turning out to be more complex than I expected. The content starts in a focused state but loses focus when the search box is clicked. We'll have to restore focus when a search result is selected. Let me try fixing this.
2 participants
Re-opened: #1421