Make package sources independent #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents unnecessary rebuilds of packages that haven't really changed, except for a hash that included irrelevant sources. By applying a trivial source filter, we create a new store path that only contains the subdirectory that the build cares about. This isn't 100% compatible with all projects, as some packages might "legitimately" depend on files outside of their own directory. We could support this by adding an option for sources to be unioned, but a source union function isn't available, _yet_. For progress, check NixOS/nixpkgs#112083 As a workaround we may allow the filtering to be disabled entirely. This could be implemented as a `packages.<name>.filteredSource` option with a default, but for now that seems over-engineered.
2 tasks
srid
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents unnecessary rebuilds of packages that haven't really changed, except for a hash that included irrelevant sources.
By applying a trivial source filter, we create a new store path that only contains the subdirectory that the build cares about.
This isn't 100% compatible with all projects, as some packages might "legitimately" depend on files outside of their own directory. We could support this by adding an option for sources to be unioned, but a source union function isn't available, yet. For progress, check NixOS/nixpkgs#112083
As a workaround we may allow the filtering to be disabled entirely. This could be implemented as a
packages.<name>.filteredSourceoption with a default, but for now that seems over-engineered.