Skip to content

Enable pytype for everything that doesn't require any changes. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable pytype for everything that doesn't require any changes. #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions refex/python/matcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,7 @@ def _coerce_list(values):
_IS_SUBMATCHER_LIST_ATTRIB = __name__ + '._IS_SUBMATCHER_LIST_ATTRIB'


def submatcher_attrib(
*args,
**kwargs: Any): # TODO: make walk a kwarg when Py2 support is dropped.
def submatcher_attrib(*args, walk: bool = True, **kwargs: Any):
"""Creates an attr.ib that is marked as a submatcher.

This will cause the matcher to be automatically walked as part of the
Expand All @@ -199,15 +197,13 @@ def submatcher_attrib(
Returns:
An attr.ib()
"""
if kwargs.pop('walk', True):
if walk:
kwargs.setdefault('metadata', {})[_IS_SUBMATCHER_ATTRIB] = True
kwargs.setdefault('converter', coerce)
return attr.ib(*args, **kwargs)


def submatcher_list_attrib(
*args,
**kwargs: Any): # TODO: make walk a kwarg when Py2 support is dropped.
def submatcher_list_attrib(*args, walk: bool = True, **kwargs: Any):
"""Creates an attr.ib that is marked as an iterable of submatchers.

This will cause the matcher to be automatically walked as part of the
Expand All @@ -222,7 +218,7 @@ def submatcher_list_attrib(
Returns:
An attr.ib()
"""
if kwargs.pop('walk', True):
if walk:
kwargs.setdefault('metadata', {})[_IS_SUBMATCHER_LIST_ATTRIB] = True
kwargs.setdefault('converter', _coerce_list)
return attr.ib(*args, **kwargs)
Expand Down