Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Nov 9, 2025

Accept davs replicas and prioritize these first. (To be discussed if we want to keep this order, but it's inspired by discussions at the 2025 retreat.)

@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.16%. Comparing base (2bd6e3e) to head (015d731).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1204      +/-   ##
===========================================
+ Coverage    85.77%   86.16%   +0.39%     
===========================================
  Files           94       94              
  Lines         3191     3347     +156     
  Branches       359      388      +29     
===========================================
+ Hits          2737     2884     +147     
- Misses         380      390      +10     
+ Partials        74       73       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the WebDAV Secure (davs) protocol by including "davs" in the list of supported schemes when listing replicas from Rucio, and converting davs URLs to https for use by the transformer.

  • Added "davs" to the list of schemes requested from Rucio's replica client
  • Implemented URL conversion from davs:// to https:// in the transformer pipeline
  • Integrated the conversion step into the file path processing flow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
did_finder_rucio/src/rucio_did_finder/rucio_adapter.py Added "davs" to the list of schemes for replica listing to enable retrieval of WebDAV Secure URLs
transformer_sidecar/src/transformer_sidecar/transformer.py Added re import, implemented change_davs_to_https function, and integrated davs-to-https URL conversion into the transform_file pipeline

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ponyisi
Copy link
Collaborator Author

ponyisi commented Nov 13, 2025

Addresses #1174

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@BenGalewsky BenGalewsky marked this pull request as draft November 13, 2025 16:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ponyisi
Copy link
Collaborator Author

ponyisi commented Nov 14, 2025

Following discussion I am going to deprioritize davs vs rootd for now, but keep the replicas in the list.

@ponyisi ponyisi marked this pull request as ready for review November 16, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants