-
-
Notifications
You must be signed in to change notification settings - Fork 23
Enable davs replicas in the Rucio DID finder
#1204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1204 +/- ##
===========================================
+ Coverage 85.77% 86.16% +0.39%
===========================================
Files 94 94
Lines 3191 3347 +156
Branches 359 388 +29
===========================================
+ Hits 2737 2884 +147
- Misses 380 390 +10
+ Partials 74 73 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the WebDAV Secure (davs) protocol by including "davs" in the list of supported schemes when listing replicas from Rucio, and converting davs URLs to https for use by the transformer.
- Added "davs" to the list of schemes requested from Rucio's replica client
- Implemented URL conversion from davs:// to https:// in the transformer pipeline
- Integrated the conversion step into the file path processing flow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| did_finder_rucio/src/rucio_did_finder/rucio_adapter.py | Added "davs" to the list of schemes for replica listing to enable retrieval of WebDAV Secure URLs |
| transformer_sidecar/src/transformer_sidecar/transformer.py | Added re import, implemented change_davs_to_https function, and integrated davs-to-https URL conversion into the transform_file pipeline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Addresses #1174 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Following discussion I am going to deprioritize davs vs rootd for now, but keep the replicas in the list. |
Accept
davsreplicas and prioritize these first. (To be discussed if we want to keep this order, but it's inspired by discussions at the 2025 retreat.)