Skip to content

Conversation

@MattShirley
Copy link
Collaborator

Fix formatting of x509 CronJob deployment.

Fixes this error I encountered locally in develop:

Error: INSTALLATION FAILED: 1 error occurred:
	* CronJob.batch "x509-secrets" is invalid: [spec.jobTemplate.spec.template.spec.containers: Required value, spec.jobTemplate.spec.template.spec.restartPolicy: Required value: valid values: "OnFailure", "Never"]

@MattShirley MattShirley marked this pull request as ready for review November 17, 2025 19:25
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.93%. Comparing base (0bfd9f9) to head (58ed8a3).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1212   +/-   ##
========================================
  Coverage    85.93%   85.93%           
========================================
  Files           94       94           
  Lines         3235     3235           
  Branches       371      371           
========================================
  Hits          2780     2780           
  Misses         380      380           
  Partials        75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ponyisi
Copy link
Collaborator

ponyisi commented Nov 17, 2025

I've requested a second plain Job to make sure that the X509 secrets are obtained at the initialization of the ServiceX deployment, not just when the first cron job schedule occurs.

@MattShirley MattShirley requested a review from ponyisi November 18, 2025 16:24
@MattShirley
Copy link
Collaborator Author

@ponyisi I added the additional k8s Job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants