make jwt optional inside get_requesting_user without throwing a 500 error

[MattShirley]

Make JWT optional (as already defined in the decorator) inside get_requesting_user without throwing a 500 error.

[codecov]

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.99%. Comparing base (c0246c7) to head (4c04d3d).

Files with missing lines	Patch %	Lines
...ex_app/servicex_app/resources/servicex_resource.py	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1213      +/-   ##
===========================================
+ Coverage    85.93%   85.99%   +0.05%     
===========================================
  Files           94       94              
  Lines         3235     3255      +20     
  Branches       371      374       +3     
===========================================
+ Hits          2780     2799      +19     
  Misses         380      380              
- Partials        75       76       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ponyisi]

Hi @MattShirley - I don't think this is quite what I was after, although I guess it addresses another failure mode.

The place where we are currently failing wrt Nebraska is the jwt_required decorator itself. Even if the optional argument is specified, if a token is present in the request, it will attempt to validate it. If ENABLE_AUTH is false, this validation will fail and the request will be rejected. The optional argument only means that the requests with no token will be accepted. So we need a new decorator that wraps jwt_required which skips all the logic if ENABLE_AUTH is false (or otherwise perhaps a super-decorator that returns jwt_required or a dummy depending on the configuration).

[MattShirley]

@ponyisi I added a no-op/dummy pass through decorator