Use timezone-aware datetime for dataset lifecycle comparisons #1214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #1211: datetime comparisons in dataset lifecycle operations were mixing naive and timezone-aware datetime objects, causing inconsistent behavior.
Changes
dataset_lifecycle_ops.py: Changeddatetime.now()todatetime.now(timezone.utc)for timezone-aware comparisonstest_dataset_lifecycle_ops.py: Updated test fixtures to use timezone-aware datetimes for consistencyContext
The
last_updatedfield is set usingdatetime.now(tz=timezone.utc)indataset_manager.py. Comparing it with a naive datetime fromdatetime.now()can fail or produce incorrect results depending on the Python version and database driver.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.