Populate transmit timestamp in request and verify the originate timestamp in the response matches. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tamp in the response matches. This fixes the case where we end up reading a previous response pakcet, whose timestamp may now be out of date by the update interval (e.g. 60 sec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where we end up reading a previous response packet, whose timestamp may now be out of date by the update interval (e.g. 60 sec)
A state of receiving the previous response packet can persist for very long periods (because we send a new packet at each update that will then be received - late - at the next update, and so on until a response packet is actually lost).