Conversation
nwparker
force-pushed
the
nwparker/notis-2
branch
from
f257122 to
d7a775a
Compare
Dedupe notifications by worktree instead of by source+worktree so that an agent-task-complete and terminal-bell firing in the same data chunk only produce one notification. Flatten the NotificationsPane layout, fix duplicate preload type declarations, and add aria-label to toggles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nwparker
force-pushed
the
nwparker/notis-2
branch
from
d7a775a to
fd2c930
Compare
The allWorktrees() selector in TerminalPane created a new array reference on every store update (.flat() always returns new), causing the component to re-render on any state change — likely the blank screen on worktree open. Extract to useNotificationDispatch which reads store state at dispatch time via getState() instead of selectors, making the callback stable (depends only on worktreeId). Also brings TerminalPane under the 400-line max-lines lint rule. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Clicking a notification now brings Orca to the foreground and switches to the worktree that triggered it, reusing the existing ui:activateWorktree IPC channel. Also adds permission status detection via systemPreferences.getNotificationSettings() on macOS, showing a warning banner in the settings pane when notifications are blocked with a button to open System Settings directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Cast systemPreferences through unknown for macOS-only getNotificationSettings() which is absent from Electron's cross-platform type definitions - Fix test helper typing for mock.calls.find() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design
Test plan
pnpm test src/main/ipc/notifications.test.ts src/main/ipc/register-core-handlers.test.ts src/renderer/src/lib/agent-status.test.tspnpm run typecheckpnpm exec oxlint src/main/ipc/notifications.ts src/main/ipc/notifications.test.ts src/main/ipc/register-core-handlers.ts src/main/ipc/register-core-handlers.test.ts src/main/persistence.ts src/preload/index.ts src/preload/index.d.ts src/shared/types.ts src/shared/constants.ts src/renderer/src/store/slices/settings.ts src/renderer/src/components/terminal-pane/pty-connection.ts src/renderer/src/components/terminal-pane/pty-transport.ts src/renderer/src/components/terminal-pane/use-terminal-pane-lifecycle.ts src/renderer/src/components/terminal-pane/TerminalPane.tsx src/renderer/src/lib/agent-status.ts src/renderer/src/components/settings/NotificationsPane.tsx src/renderer/src/components/settings/Settings.tsx