restore single update toast and cover updater transitions#299
Merged
AmethystLiang merged 3 commits intomainfrom Apr 4, 2026
Merged
restore single update toast and cover updater transitions#299AmethystLiang merged 3 commits intomainfrom
AmethystLiang merged 3 commits intomainfrom
Conversation
AmethystLiang
changed the title
- Replace smart quote (U+2019) with ASCII apostrophe in update toast test - Use .at(-1) instead of array[length - 1] per prefer-at rule - Extract background context menu into FileExplorerBgMenu to fix max-lines
The old UpdateReminder component checked dismissedUpdateVersion before showing the update prompt. This logic was missing from the new createUpdateToastController, causing the toast to reappear even after the user dismissed it. Now the controller skips the available toast when the version matches the dismissed one and persists the dismissal when the user closes the toast without clicking Update.
AmethystLiang
force-pushed
the
fix-updater-2
branch
from
d853d17 to
fb03c5f
Compare
AmethystLiang
added a commit
that referenced
this pull request
Apr 5, 2026
PR #299 introduced a regression where the one-click auto-update flow would synchronously invoke `quitAndInstall` immediately upon receiving the `downloaded` state transition. This triggered a synthetic `beforeunload` event (to capture terminal buffers) and an IPC call to quit in the exact same event loop tick that React and the Toast library were processing state updates. This disrupted the renderer's synchronous shutdown and flush logic, causing the app to fail to quit and install properly. This adds a `setTimeout` to defer `quitAndInstall`, pushing it to the bottom of the event queue. This allows the UI state to settle and ensures the `beforeunload` flush sequence executes cleanly. Test cases have also been updated to use fake timers.
AmethystLiang
added a commit
that referenced
this pull request
Apr 5, 2026
* fix: defer updater quitAndInstall to allow React/UI state to settle PR #299 introduced a regression where the one-click auto-update flow would synchronously invoke `quitAndInstall` immediately upon receiving the `downloaded` state transition. This triggered a synthetic `beforeunload` event (to capture terminal buffers) and an IPC call to quit in the exact same event loop tick that React and the Toast library were processing state updates. This disrupted the renderer's synchronous shutdown and flush logic, causing the app to fail to quit and install properly. This adds a `setTimeout` to defer `quitAndInstall`, pushing it to the bottom of the event queue. This allows the UI state to settle and ensures the `beforeunload` flush sequence executes cleanly. Test cases have also been updated to use fake timers. * fix: centralize updater restart deferral in main process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing