feat(boil): Support Containerfiles per version#1302
Conversation
Yes, that's how it works. I was actually thinking about adding support for YAML-based configs, because that would allow more compact configs. See the comparison of two full configs below: # Version 1.8.0
[versions."1.8.0"]
containerfile = "Dockerfile"
[versions."1.8.0".local-images]
stackable-devel = "1.0.0"
vector = "0.49.0"
[versions."1.8.0".build-arguments]
golang-version = "1.24.6"
# Version 1.4.2
[versions."1.4.2".local-images]
stackable-devel = "1.0.0"
vector = "0.49.0"
[versions."1.4.2".build-arguments]
golang-version = "1.23.9"versions:
1.8.0:
containerfile: Dockerfile
local-images:
stackable-devel: 1.0.0
vector: 0.49.0
build-arguments:
golang-version: 1.24.6
1.4.2:
local-images:
stackable-devel: 1.0.0
vector: 0.49.0
build-arguments:
golang-version: 1.23.9What's your take on this @NickLarsenNZ?
Will do. |
|
I'd prefer if we could keep the terminology "Dockerfile" because that's what they are. |
I like |
I'd argue that we are not making any promises on what we (as in As such, we should use an agnostic name to convey that people can use whatever name/feature as long as it is supported. But I'm happy to rename it, if you feel strongly about it. |
Note
This might come in handy for Airflow 2 + 3.
This PR enables setting a custom Containerfile per version.
This feature is especially useful if two versions of the same image use build pipelines. It cuts down on any branching needed in Containerfiles.
Example