feat(hbase): add hbase-entrypoint.sh script#898
Merged
Conversation
NickLarsenNZ
approved these changes
Oct 23, 2024
Member
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Approving so we aren't blocked, but would like some light docs on the traps/signal handlin.
Member
|
@razvan would we revert this if we decide not to merge the other related graceful shutdown tickets? |
Member
Author
|
It's not used and has no impact if it stays. Personally I would prefer to create entry point scripts for all products and get rid of the hard-coded shell snippets in the operators. But if it bothers you, I can revert it. |
Member
|
It doesn't. I was just wondering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
prere-quisite for : stackabletech/hbase-operator#570
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.