fix: cleanup header structure #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the broken search functionality in the docs.
I did this:
pagefind-modular-ui.jsintohead-scripts.hbs(where all the other scripts are loaded) so that it's part of the<head>tag (and not<body>)header-scripts.hbssince it was now emptyheader-content.hbstoheader.hbs.header.hbswas there before and includedheader-scriptsandheader-content. Sinceheader-scriptsis now gone it can just include the content ofheader-contentdirectly.This now includes the pagefind JS on my local machine in the HTML source.
I suspect that adding the Mermaid extension in stackabletech/documentation#791 might have broken it, since Mermaid is now the first script right after the
<body>tag. I have not investigated this further though, since consolidating the loading of scripts in one place seems like the right thing to do and already fixed the problem.