Merged
Conversation
razvan
reviewed
Feb 12, 2025
Member
razvan
left a comment
There was a problem hiding this comment.
This doesn't fix the warning for me.
Removing the accolades fixes it.
diff --git a/docs/modules/hbase/pages/usage-guide/overrides.adoc b/docs/modules/hbase/pages/usage-guide/overrides.adoc
index b27302b..29adc83 100644
--- a/docs/modules/hbase/pages/usage-guide/overrides.adoc
+++ b/docs/modules/hbase/pages/usage-guide/overrides.adoc
@@ -104,10 +104,10 @@ Using JVM argument overrides you can configure the JVM arguments xref:concepts:o
One thing that is different for Kafka, is that all heap-related arguments will be passed in via the env variable `HBASE_HEAPSIZE`, all the other ones via `HBASE_OPTS`, `HBASE_MASTER_OPT
S`, `HBASE_REGIONSERVER_OPTS` and `HBASE_REST_OPTS`.
The `HBASE_HEAPSIZE` variable is documented as follows in the https://cwiki.apache.org/confluence/display/HADOOP2/Hbase+FAQ+Operations[HBase FAQs]:
-> Set the `HBASE_HEAPSIZE` environment variable in `${HBASE_HOME}/conf/hbase-env.sh` if your install needs to run with a larger heap.
+> Set the `HBASE_HEAPSIZE` environment variable in `$HBASE_HOME/conf/hbase-env.sh` if your install needs to run with a larger heap.
> `HBASE_HEAPSIZE` is like `HADOOP_HEAPSIZE` in that its value is the desired heap size in MB.
> The surrounding '-Xmx' and 'm' needed to make up the maximum heap size java option are added by the hbase start script
-> (See how `HBASE_HEAPSIZE` is used in the `${HBASE_HOME}/bin/hbase` script for clarification).
+> (See how `HBASE_HEAPSIZE` is used in the `$HBASE_HOME/bin/hbase` script for clarification).
Looking at `bin/hbase`, you can actually add the `m` suffix to make the unit more clear, the script will detect this https://github.com/apache/hbase/blob/777010361abb203b8b17673d84acf4f7f1d0283a/bin/hbase#L165[here] and work correctly.
Member
Author
|
Thanks for the patch! It changes the quote a bit, but YOLO BTW, very strange that it tries to interpret stuff in single quotes :/ |
razvan
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes