Skip to content

fix: loose ends and cleanups#900

Merged
razvan merged 6 commits intomainfrom
fix/loose-ends
Oct 16, 2025
Merged

fix: loose ends and cleanups#900
razvan merged 6 commits intomainfrom
fix/loose-ends

Conversation

@razvan
Copy link
Member

@razvan razvan commented Oct 16, 2025

Description

  • a bit of code cleanup
  • remove the metric port from services that don't need it
  • use the new server.yaml for jmx configuration
  • update metrics tests
  • update monitoring doc

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@razvan razvan self-assigned this Oct 16, 2025
maltesander
maltesander approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 3dddc6d Oct 16, 2025
17 checks passed
@razvan razvan deleted the fix/loose-ends branch October 16, 2025 12:12
razvan added a commit that referenced this pull request Oct 17, 2025
@razvan
fix: loose ends and cleanups (#900)
6c2dfa7 
* group kerberos code together

* clean up bootstrap listener ports

* update metrics.py to actually test for the existence of metrics

* read jmx config from server.yaml instead of broker.yaml

* update docs

* update changelog
github-merge-queue bot pushed a commit that referenced this pull request Oct 21, 2025
@razvan @maltesander
feat: create client.properties for use with kafka scripts (#898)
5b6a022 
* create client.properties and update tls tests

* fix: loose ends and cleanups (#900)

* group kerberos code together

* clean up bootstrap listener ports

* update metrics.py to actually test for the existence of metrics

* read jmx config from server.yaml instead of broker.yaml

* update docs

* update changelog

* add comment about the kerberos situation

* update docs to remove kcat references

* remove comments from client.properties

* fix topic creation

* remove kcat from upgrade test

* update changelog

* Update CHANGELOG.md

Co-authored-by: Malte Sander <contact@maltesander.com>

* Apply suggestions from code review

Co-authored-by: Malte Sander <contact@maltesander.com>

* implement review feedback

---------

Co-authored-by: Malte Sander <contact@maltesander.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@razvan razvan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@razvan @maltesander