Conversation
adwk67
commented
Jul 28, 2025
Member
Author
adwk67
left a comment
adwk67
left a comment
There was a problem hiding this comment.
I've left a few in-line comments where I'm not 100% certain about things. I've also left the cluster-wide service untouched - should this be removed and each role group listener address combiend and used for discovery.seed_hosts?
rust/operator-binary/src/controller/build/role_group_builder.rs
Outdated
Show resolved
Hide resolved
rust/operator-binary/src/controller/build/role_group_builder.rs
Outdated
Show resolved
Hide resolved
siegfriedweber
requested changes
Jul 29, 2025
rust/operator-binary/src/controller/build/role_group_builder.rs
Outdated
Show resolved
Hide resolved
rust/operator-binary/src/controller/build/role_group_builder.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #16
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker