feat: OPA TLS support #812
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dervoeti
force-pushed
the
feat/opa-tls-support
branch
from
fe2ed01 to
2767a27
Compare
20 tasks
dervoeti
force-pushed
the
feat/opa-tls-support
branch
from
2ce7dba to
2f9083c
Compare
maltesander
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
maltesander
previously approved these changes
Oct 31, 2025
| .is_some() | ||
| { | ||
| prepare_args.extend(command::add_cert_to_truststore( | ||
| &format!("/stackable/secrets/{OPA_TLS_VOLUME_NAME}/ca.crt"), |
There was a problem hiding this comment.
The format / naming be a method on the trino_opa_config returning the optional mount path? Used in the tls_volume_mounts method as well.
dervoeti
force-pushed
the
feat/opa-tls-support
branch
from
707fc8f to
261b602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/opa-operator#581
Needs stackabletech/opa-operator#774
Adds support for OPA with TLS for Trino.
The discovery currently happens via an additional attribute in the service discovery
ConfigMapwhich provides the name of theSecretClass. TBD if doing it this way is fine for now.The OPA test was adapted to test OPA with TLS enabled.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker