-
Notifications
You must be signed in to change notification settings - Fork 13
Start Zuul testing with multiple nodes #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cityofships, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request expands the continuous integration testing for Cephadm by introducing multi-node configurations for Ubuntu Jammy environments. This change enables more comprehensive testing of Ceph deployments, moving beyond single-node setups to better simulate real-world distributed cluster scenarios.
Highlights
- Zuul Job Configuration Update: Modified existing Zuul jobs (
cephadm-jammy-singlenode-docker-reefandcephadm-jammy-singlenode-podman-reef) to use a new multi-node setup, renaming them tocephadm-jammy-multinode-docker-reefandcephadm-jammy-multinode-podman-reefrespectively. - New Multi-Node Definition: Introduced a new
cephadm-jammy-multinodenodeset in Zuul, defining a three-node cluster (ceph-1,ceph-2,ceph-3) with Ubuntu Jammy labels, and assigning them toceph,mons,mgrs, andosdsgroups.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Zuul configuration to run tests on a multi-node setup instead of a single node. The changes in zuul.d/jobs.yaml correctly rename the jobs and update them to use the new cephadm-jammy-multinode nodeset. The new nodeset defined in zuul.d/nodesets.yaml correctly sets up a 3-node environment. However, a critical file, zuul.d/project.yaml, has not been updated to use the new job names (cephadm-jammy-multinode-docker-reef and cephadm-jammy-multinode-podman-reef). Without this change, the new multi-node tests will not be triggered in check and gate pipelines. Please update zuul.d/project.yaml accordingly. I've also added a suggestion to improve the maintainability of the new nodeset definition.
bc29ad3 to
787e563
Compare
No description provided.