Skip to content

Conversation

@dougszumski
Copy link
Member

@dougszumski dougszumski commented Oct 29, 2025

This patch is required urgently for Cambridge. It is unlikely
that we can wait for the upstream patch to merge:
https://review.opendev.org/c/openstack/networking-generic-switch/+/965373

This driver uses the sonic-cli rather than Linux userspace to
configure the switch. This is because LLDP advertises switch
ports based on the naming from the sonic-cli, which is not the
same as Linux userspace.

Note the existing Dell SONiC driver is using the Linux namespace
netmiko driver, which is not suitable.

@dougszumski dougszumski requested a review from a team as a code owner October 29, 2025 16:31
@dougszumski
Copy link
Member Author

pep8 fail is unrelated

@dougszumski dougszumski force-pushed the feature/dell_sonic_cli branch from a855505 to f810370 Compare October 29, 2025 16:57
This patch is required urgently for Cambridge. It is unlikely
that we can wait for the upstream patch to merge:
https://review.opendev.org/c/openstack/networking-generic-switch/+/965373

This driver uses the `sonic-cli` rather than Linux userspace to
configure the switch. This is because LLDP advertises switch
ports based on the naming from the `sonic-cli`, which is not the
same as Linux userspace.

Note the existing Dell SONiC driver is using the Linux namespace
netmiko driver, which is not suitable.

Change-Id: Ia79de43a33c19f7b80bd0ef29badee464cd6fc0c
Signed-off-by: Doug Szumski <doug@stackhpc.com>
@dougszumski dougszumski force-pushed the feature/dell_sonic_cli branch from f810370 to 249fd80 Compare October 30, 2025 17:42
Change-Id: Ia837bd2cca37158897dcd6656915df210422c217
@mnasiadka
Copy link
Member

Is there a reason it doesn't support trunk?
Should we first merge it in 2025.1?

@dougszumski
Copy link
Member Author

Is there a reason it doesn't support trunk? Should we first merge it in 2025.1?

Good questions. They don't want to configure trunk ports, they would just turn off that feature. I could add it if we have these switches somewhere else. I was hoping to backport the upstream patch if I can get it merged, but this could also go to 2025.1 first if you'd prefer.

@mnasiadka
Copy link
Member

Is there a reason it doesn't support trunk? Should we first merge it in 2025.1?

Good questions. They don't want to configure trunk ports, they would just turn off that feature. I could add it if we have these switches somewhere else. I was hoping to backport the upstream patch if I can get it merged, but this could also go to 2025.1 first if you'd prefer.

Ok then - let's try to update the upstream patch with trunk (since trunking is normally supported since 2025.1) - and merge this one in 2024.1. If you need any help in adding the trunk commands or gaining traction from the Ironic community - please let me know :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants