-
Couldn't load subscription status.
- Fork 134
Proposal to refactor the MCP Registry controller #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2301 +/- ##
==========================================
- Coverage 54.28% 54.25% -0.03%
==========================================
Files 240 242 +2
Lines 23594 23446 -148
==========================================
- Hits 12808 12721 -87
+ Misses 9577 9516 -61
Partials 1209 1209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for this @dmartinol I'll mark this to review when ive got a bit of downtime! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of comments inline but in general I think this looks great.
Also tagging @rdimitrov @ChrisJBurns for visibility, but my take is let's clear the minor comments, merge, file issues and let's go.
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments.
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Addresses #2287