Skip to content

Conversation

@dmartinol
Copy link
Collaborator

Addresses #2287

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.25%. Comparing base (0c44157) to head (51a162e).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
- Coverage   54.28%   54.25%   -0.03%     
==========================================
  Files         240      242       +2     
  Lines       23594    23446     -148     
==========================================
- Hits        12808    12721      -87     
+ Misses       9577     9516      -61     
  Partials     1209     1209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisJBurns
Copy link
Collaborator

Thanks for this @dmartinol I'll mark this to review when ive got a bit of downtime!

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of comments inline but in general I think this looks great.

Also tagging @rdimitrov @ChrisJBurns for visibility, but my take is let's clear the minor comments, merge, file issues and let's go.

dmartinol and others added 2 commits October 27, 2025 10:22
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Copy link
Contributor

@blkt blkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments.

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants