fix(tests): fix variable shadowing, untested invalid inputs, and array length mismatch in c32encoding tests#47
Open
jadonamite wants to merge 1 commit intostacks-network:masterfrom
Open
Conversation
Refactor tests to improve clarity and fix variable shadowing issues. Update comments and ensure all invalid inputs are independently tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes three bugs in the c32encoding test suite and adds inline comments for maintainability.
Changes
.map()callback parameter fromtestDatatoentryinc32encodingRandomBytesto avoid shadowing the outer arraytry/catchblocks inc32checkEncode invalid inputsinto individual blocks so every invalid case is independently testedundefinedfromhexMinLengths(had 23 elements for 22 hex strings)Testing
All existing tests pass. No new tests added — fixes ensure existing invalid input tests actually run as intended.