Skip to content

Conversation

@wileyj
Copy link
Contributor

@wileyj wileyj commented Oct 23, 2025

Adds a prometheus/cadvisor component to hacknet for tracking metrics on the hacknet services.
default up will not run this, and is optional:
make up-prom will start prometheus api and cadvisor services
make down-prom will bring down the prom and cadvisor services.

note, there is a warning due to piggybacking on the existing network name.

wileyj added 3 commits October 2, 2025 11:25
  - added 2 targets to Makefile to control prometheus/cadvisor
…ometheus

* commit '90ef0fda09876db473bcd33cad5a422976227efe':
  Adding prometheus compose to track system resources during netowrk test   - added 2 targets to Makefile to control prometheus/cadvisor
@wileyj wileyj requested a review from BowTiedRadone October 23, 2025 17:57
BowTiedRadone
BowTiedRadone previously approved these changes Oct 24, 2025
Copy link
Contributor

@BowTiedRadone BowTiedRadone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left only one question, but approving up-front since I already tested the functionality locally multiple times.

@wileyj
Copy link
Contributor Author

wileyj commented Oct 24, 2025

let's hold off on merging this - i realized we need to add the linter check for this new compose file (of which there are some warnings being thrown locally).

i'll fix and add a commit to address before merging

- Updating compose files based on linter output.
- Updating workflow to check all compose files in ./docker/
- Updated dclintrc to ignore quotes for ports (default only passes with
  single quotes, not double quotes)
Copy link
Contributor

@BowTiedRadone BowTiedRadone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wileyj wileyj merged commit df72fc1 into stacks-network:master Oct 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants