Added tenure size checker/limiter

[rdeioris]

Description

This patch introduces monitoring and limiting for the size of a whole tenure. Note that tenure extend resets the counter.

For allowing more targeted tests, it introduces a config option for the miner (not exposed to the file based configuration) for enabling logging of skipped transactions (that are not logged or sent to the event system).

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[obycode]

Added some comments for improvements.

One thing I think it missing is an update to the code where the miner decides whether or not it should attempt to tenure extend, see stacks-node/src/nakamoto_node/miner.rs:1676

                // Do not extend if we have spent < 50% of the budget, since it is
                // not necessary.
                let usage = self
                    .tenure_budget
                    .proportion_largest_dimension(&self.tenure_cost);
                if usage < self.config.miner.tenure_extend_cost_threshold {
                    return Ok(NakamotoTenureInfo {
                        coinbase_tx: None,
                        tenure_change_tx: None,
                    });
                }

I think it should also attempt to extend if the size is >50% of the budget.

[jcnelson]

I'm not seeing the code where the miner checks max_tenure_size to stop mining blocks?

[rdeioris]

I'm not seeing the code where the miner checks max_tenure_size to stop mining blocks?

I did it for allowing smaller transactions to be included (given that the check is done at transaction inclusion). The only case I see for completely disabling block mining is if the current tenure size is so near to the limit that it is impossibile for any transaction to be included

[rdeioris]

Added some comments for improvements.

One thing I think it missing is an update to the code where the miner decides whether or not it should attempt to tenure extend, see stacks-node/src/nakamoto_node/miner.rs:1676

                // Do not extend if we have spent < 50% of the budget, since it is
                // not necessary.
                let usage = self
                    .tenure_budget
                    .proportion_largest_dimension(&self.tenure_cost);
                if usage < self.config.miner.tenure_extend_cost_threshold {
                    return Ok(NakamotoTenureInfo {
                        coinbase_tx: None,
                        tenure_change_tx: None,
                    });
                }

I think it should also attempt to extend if the size is >50% of the budget.

Love it, working on it

[jcnelson]

Looks like CI is still failing

[rdeioris]

@jcnelson @brice-stacks i have removed the miner logic for automatic tenure extend based on tenure size. Before merging i think it is worthy to be sure that DEFAULT_MAX_TENURE_BYTES (currently 10 MB) is a solid value. (currently it has been choosen fully arbitrary)

[jcnelson]

Just need answers to a couple of comments.

[brice-stacks]

LGTM!