Improve Ruby partial rendering detection using regex patterns#378
Open
jessejackson85 wants to merge 7 commits intostakwork:mainfrom
Open
Improve Ruby partial rendering detection using regex patterns#378jessejackson85 wants to merge 7 commits intostakwork:mainfrom
jessejackson85 wants to merge 7 commits intostakwork:mainfrom
Conversation
6fbafd0 to
d845cb0
Compare
811de80 to
05c5515
Compare
Contributor
Author
|
@Evanfeenstra Please review this PR. |
Collaborator
|
there is testing for each language in ast/src/testing To update whenever a new feature is added |
Contributor
Author
@Evanfeenstra Sure. |
Contributor
Author
|
@Evanfeenstra I've pushed the newly added feature here. Please review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR improves the detection of Ruby on Rails partials by using regex patterns instead of tree-sitter. It extracts partial names from template files (.erb, .haml, .slim) and Ruby controller files (.rb) to create accurate RENDERS edges in the dependency graph.
Key changes:
render partial:,<%= render, etc.)Fixes the issue where partial relationships weren't properly detected in Rails applications.
Closed #136