Skip to content

Only asynchronously unsubscribe for user actions in public API #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matthewjamesadam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only asynchronously unsubscribe for user actions in public API #341

matthewjamesadam wants to merge 1 commit into from

Conversation

@matthewjamesadam
Copy link

@matthewjamesadam matthewjamesadam commented Feb 11, 2025 •
edited
Loading

Resolve #340 by using asynchronous unsubscription only in the public API. Internal unsubscriptions happen synchronously.

@matthewjamesadam matthewjamesadam mentioned this pull request Feb 11, 2025
Closed
@matthewjamesadam
Copy link
Author

matthewjamesadam commented Feb 11, 2025

One thing I am seeing on this branch is that when I run all the unit tests locally (using npm run test, I get failures, however if I run the tests individually (mocha tests/operators/last.ts --require ts-node/register --exit) the same tests pass. I am not sure why this would be.

@matthewjamesadam matthewjamesadam mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Subtle timing bug with .remember() dropping values

1 participant

@matthewjamesadam