Modernize build, dependencies, and scheduler performance#6
Closed
Modernize build, dependencies, and scheduler performance#6
Conversation
stanbot8
force-pushed
the
dev/stanbot8
branch
6 times, most recently
from
258639d to
e99ede2
Compare
stanbot8
changed the title
stanbot8
force-pushed
the
dev/stanbot8
branch
3 times, most recently
from
4ad5842 to
609a5fb
Compare
stanbot8
changed the title
stanbot8
force-pushed
the
dev/stanbot8
branch
6 times, most recently
from
7d1133f to
c1f5d83
Compare
The SonarSource/sonarcloud-github-c-cpp action has been removed. Migrate to SonarSource/sonarqube-scan-action@v7 and its install-build-wrapper sub-action.
log_range_param.h and range_param.h rely on <cmath> being transitively included through other headers. Adding explicit includes ensures correct builds regardless of which headers are pulled in by dependencies.
Routine dependency update. Keeps third-party code current.
stanbot8
changed the title
stanbot8
force-pushed
the
dev/stanbot8
branch
4 times, most recently
from
bc0a5db to
7891955
Compare
Migrate all TOML parsing from cpptoml to tomlplusplus. Introduce a TomlConfig typedef to insulate downstream code from the concrete library. Keep cpptoml in third_party/ with a deprecation pragma so existing includes still compile. Move BDM_ASSIGN_CONFIG_VALUE macros to a new toml_config.h and turn the old cpptoml.h utility header into a forwarding shim with a deprecation warning.
When the diffusion coefficient is 0 but decay is nonzero, apply decay as a simple element-wise multiply instead of running the full FTCS stencil. The Laplacian term vanishes with D=0, so the stencil computation is wasted work.
AddAgentsToRm runs every step in both SetupIterationAll and TearDownIterationAll. On steps where no agents were created, the function still allocated NUMA vectors, called ResizeAgentUidMap, GrowAgentContainer(0), and entered an OMP parallel region. Add an early-out scan that checks all execution contexts for empty new_agents_ and returns immediately when nothing to commit.
Execute() called Simulation::GetActive()->GetEnvironment() and GetParam() for every agent every step. These pointers are stable within an agent-ops phase, so cache them once in SetupAgentOpsAll and reuse the cached values in Execute. Eliminates two pointer chases per agent per step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cumulative branch with all pending upstream changes for review before individual PRs land.
Build and dependencies
Bug fixes
Performance
Test plan