This repository was archived by the owner on Aug 21, 2024. It is now read-only.
chore: move compilation logic to FeatureContracts enum#1869
Open
dorimedini-starkware wants to merge 1 commit intomainfrom
Open
chore: move compilation logic to FeatureContracts enum#1869dorimedini-starkware wants to merge 1 commit intomainfrom
dorimedini-starkware wants to merge 1 commit intomainfrom
Conversation
ab36a89 to
7150c66
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1869 +/- ##
==========================================
- Coverage 77.93% 77.61% -0.33%
==========================================
Files 61 62 +1
Lines 8766 8813 +47
Branches 8766 8813 +47
==========================================
+ Hits 6832 6840 +8
- Misses 1494 1533 +39
Partials 440 440 ☔ View full report in Codecov by Sentry. |
fdc6378 to
3c6d246
Compare
7150c66 to
7fba16f
Compare
Collaborator
Author
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @OriStarkware and @Yoni-Starkware)
crates/blockifier/src/test_utils/cairo_compile.rs line 10 at r1 (raw file):
} if !debug_info { command.args([&path, "--no_debug_info"]);
blocking self: path arg needs to be added regardless of debug info flag
Code quote:
command.args([&path, "--no_debug_info"]);3c6d246 to
9829f40
Compare
Signed-off-by: Dori Medini <dori@starkware.co>
7fba16f to
72f5494
Compare
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
* fix: ensure correct subdmodule path and rev for solidity forge-std * fix: adjust messaging guide for L1-L2 messaging * fix: adjust messaging guide for L1-L3 messaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is