This repository was archived by the owner on Aug 21, 2024. It is now read-only.
feat: derive Clone for call info related types#1950
Open
odesenfans wants to merge 1 commit intostarkware-libs:mainfrom
Open
feat: derive Clone for call info related types#1950odesenfans wants to merge 1 commit intostarkware-libs:mainfrom
odesenfans wants to merge 1 commit intostarkware-libs:mainfrom
Conversation
Context: Starknet OS port to Rust. The current port relies on a fork of Blockifier which implements these traits. If this can go upstream this would make our life easier.
odesenfans
added a commit
to Moonsong-Labs/snos
that referenced
this pull request
Jun 4, 2024
Now that `cairo-vm` supports `cairo-lang` 2.6.x, we can upgrade a few dependencies. * Created a new fork of blockifier to use latest stable (0.5.0) + a few modifications because we want `Clone` implementations. PRed the fork to upstream blockifier (starkware-libs/blockifier#1950). * Bumped cairo-vm to latest main * Removed the constraint to 2.5.4 for cairo-lang-* crates.
odesenfans
added a commit
to Moonsong-Labs/snos
that referenced
this pull request
Jun 4, 2024
Now that `cairo-vm` supports `cairo-lang` 2.6.x, we can upgrade a few dependencies. * Created a new fork of blockifier to use latest stable (0.5.0) + a few modifications because we want `Clone` implementations. PRed the fork to upstream blockifier (starkware-libs/blockifier#1950). * Bumped cairo-vm to latest main * Removed the constraint to 2.5.4 for cairo-lang-* crates.
9 tasks
odesenfans
pushed a commit
to keep-starknet-strange/snos
that referenced
this pull request
Jun 4, 2024
Now that `cairo-vm` supports `cairo-lang` 2.6.x, we can upgrade a few dependencies. * Created a new fork of blockifier to use latest stable (0.5.0) + a few modifications because we want `Clone` implementations. PRed the fork to upstream blockifier (starkware-libs/blockifier#1950). * Bumped cairo-vm to latest main * Removed the constraint to 2.5.4 for cairo-lang-* crates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: Starknet OS port to Rust.
The current port relies on a fork of Blockifier which implements these traits. If this can go upstream this would make our life easier.
This change is