This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Open
Conversation
dan-starkware
changed the title
dorimedini-starkware
approved these changes
Jul 7, 2024
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)
dorimedini-starkware
suggested changes
Jul 7, 2024
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
a discussion (no related file):
approved wrong Pr
dorimedini-starkware
suggested changes
Jul 7, 2024
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
approved wrong Pr
close this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is