Improved mappers to points to the generating attributes. #8822
+114
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
TomerStarkware
approved these changes
Dec 3, 2025
Collaborator
TomerStarkware
left a comment
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
orizi
changed the base branch from
orizi/12-02-added_tests_for_diagnostics_from_generated_code_being_mapped_to_full_function
to
graphite-base/8822
orizi
force-pushed
the
orizi/12-02-improved_mappers_to_points_to_the_generating_attributes
branch
from
93cc878 to
dcfb1f9
Compare
orizi
force-pushed
the
graphite-base/8822
branch
from
dccf0bc to
dc825ea
Compare
orizi
deleted the
orizi/12-02-improved_mappers_to_points_to_the_generating_attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.