fix: replace unsafe zeroed() with MaybeUninit in split_at#1237
Open
crStiv wants to merge 2 commits intostarkware-libs:devfrom
Open
fix: replace unsafe zeroed() with MaybeUninit in split_at#1237crStiv wants to merge 2 commits intostarkware-libs:devfrom
crStiv wants to merge 2 commits intostarkware-libs:devfrom
Conversation
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace std::mem::zeroed() with MaybeUninit for safe array initialization in ArrayOfVecs split_at method.
References don't have a zero representation, so zeroed() was creating invalid values leading to potential UB.
The fix uses MaybeUninit arrays that are safely initialized element by element before being converted to initialized arrays via array_assume_init().
Also removed the #[allow(invalid_value)] attribute that's no longer needed.