Skip to content

set ik_loop_count in stabilizer param for hrp2017#550

Closed
mmurooka wants to merge 13 commits intostart-jsk:masterfrom
mmurooka:st-ik-loop
Closed

set ik_loop_count in stabilizer param for hrp2017#550
mmurooka wants to merge 13 commits intostart-jsk:masterfrom
mmurooka:st-ik-loop

Conversation

@mmurooka
Copy link
Copy Markdown
Member

For real hrp2017 robot.

@mmurooka mmurooka requested review from iory and snozawa and removed request for snozawa June 29, 2018 09:36
…sys_config.py] update hrp2017 default_zmp_offsets x: 0.01 -> 0.02 [m]
stp.eefm_swing_rot_spring_gain = [[1]*3, [1]*3, [0]*3, [0]*3]
# IK
for ikp in stp.ik_limb_parameters:
ikp.ik_loop_count=1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stabilizer自体のik_loop_countは3ですが、1になっても問題ないでしょうか?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrp2017のhrpsysで、ハンドが固まる、hrpsysでTimeoverが出て歩いていてガタガタしだして転びそうになる、ros_bridgeの通信が重くなって力センサのトピックがとれなくなる、などの問題を@snozawaさんに言った時に、体内ローカルに加えてくれた変更で、今までこれがある状態で、デモやみんなの実験ができていたので大丈夫だと思います。この変更はsetStAbcParametershrp2017c内なので、17号機にしか影響しません。

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど、承知しました。

@iory
Copy link
Copy Markdown
Contributor

iory commented Jul 4, 2018

Merge branchというcommitが複数あるのでrebaseしたほうが良いと思います。

@mmurooka
Copy link
Copy Markdown
Member Author

mmurooka commented Jul 4, 2018

test and review passed. could you merge this?

@mmurooka
Copy link
Copy Markdown
Member Author

mmurooka commented Jul 4, 2018

move to #551

@mmurooka mmurooka closed this Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants