Skip to content

Conversation

@sashapp
Copy link

@sashapp sashapp commented Dec 11, 2025

As mentioned in Issue #6400, I propose this change to allow to query an entire list of stash ids against the scenes in the database.

I have applied it to scenes, performers, and studios.

Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify sqlite.stashIDCriterionHandler to use stashIDsCriterionHandler rather than (mostly) duplicating the logic.

I think the existing stash_id_endpoint fields should be marked as deprecated in the graphql interface.

@WithoutPants WithoutPants added this to the Version 0.31.0 milestone Jan 6, 2026
@sashapp
Copy link
Author

sashapp commented Jan 7, 2026

Just to make sure that I understand you correctly. Do you mean I should modify sqlite.stashIDCriterionHandler to use StashIDsCriterionInput (you wrote handler in the second type name), such that no logic needs to be duplicated?

I could then just use the new handler, mark the old GraphQL endpoint as deprecated and redirect it to the new handler, wrapping its single id in a list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants