Skip to content

fix(dlna): improve activity tracking accuracy and efficiency #6483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cj12312021 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(dlna): improve activity tracking accuracy and efficiency #6483

cj12312021 wants to merge 2 commits into from
+37 −91

Conversation

@cj12312021
Copy link
Collaborator

@cj12312021 cj12312021 commented Jan 7, 2026

Summary

  • Remove play duration tracking: I think it is best due to how inaccurate the estimate would be for non-linear playback. Inaccurate estimates could skew the analytics that users may be running on that data.
  • Combine database transactions: Resume time and view count updates now happen in a single transaction instead of two separate ones. This provides atomicity (if one fails, both roll back) and better performance (one DB round-trip instead of two).

@cj12312021
fix(dlna): improve activity tracking accuracy and efficiency
85b347b 
- Remove play duration tracking: DLNA clients buffer aggressively and
  don't report playback position, making duration estimates unreliable.
  Saving inaccurate values corrupts analytics.

- Combine database transactions: Resume time and view count updates
  now happen in a single transaction for atomicity and performance.

- Keep resume time tracking: While imprecise, it provides useful
  "continue watching" hints. The cost of being wrong is low (user
  just seeks).
@cj12312021 cj12312021 added the improvement Something needed tweaking. label Jan 7, 2026
@feederbox826
Copy link
Collaborator

feederbox826 commented Jan 8, 2026

Is there any point to the play duration check? Since DLNA buffers so aggressively would it be possible to not trigger it?

@cj12312021
Copy link
Collaborator Author

cj12312021 commented Jan 8, 2026 •
edited
Loading

Is there any point to the play duration check? Since DLNA buffers so aggressively would it be possible to not trigger it?

The goal of this PR is to remove the play duration check/tracking from the DLNA service.

@feederbox826
Copy link
Collaborator

feederbox826 commented Jan 8, 2026

Sorry, I meant elapsed

https://github.com/stashapp/stash/pull/6483/changes#diff-6cd6601a8d885f37fd5d16762252c4f038a5ee7feea29b7e64ec784f65805404R265

and the corresponding check
https://github.com/stashapp/stash/pull/6483/changes#diff-6cd6601a8d885f37fd5d16762252c4f038a5ee7feea29b7e64ec784f65805404R271

@cj12312021
Copy link
Collaborator Author

cj12312021 commented Jan 8, 2026

The goal of that code was to prevent writes for sessions that lasted less than 5 seconds. The 5-second time should be more reliable to calculate, but I see the argument for removing it as well. I can push that change later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

improvement Something needed tweaking.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cj12312021 @feederbox826