Skip to content

fix: 8.4 CLI on windows #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

fix: 8.4 CLI on windows #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b63e5a
fix: 8.4 CLI on windows
SRWieZ Dec 25, 2024
ae56e02
Remove redundant patch files
crazywhalecc Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 patches/cli_static.patch → patches/cli_static_80.patch
View file
Open in desktop
File renamed without changes.
23 changes: 23 additions & 0 deletions patches/cli_static_84.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
diff --git a/sapi/cli/php_cli.c b/sapi/cli/php_cli.c
--- a/sapi/cli/php_cli.c (revision d3bf67d44102869f340a7be0e12f4f09de0edbcf)
+++ b/sapi/cli/php_cli.c (date 1735128770216)
@@ -98,7 +98,7 @@

#if defined(PHP_WIN32)
#if defined(ZTS)
-ZEND_TSRMLS_CACHE_DEFINE()
+//ZEND_TSRMLS_CACHE_DEFINE()
#endif
static DWORD orig_cp = 0;
#endif
@@ -1137,6 +1137,10 @@
#endif
{
#if defined(PHP_WIN32)
+ if (!php_win32_ioutil_init()) {
+ fprintf(stderr, "ioutil initialization failed");
+ return 1;
+ }
# ifdef PHP_CLI_WIN32_NO_CONSOLE
int argc = __argc;
char **argv = __argv;