Implement snapshots cache in aristo database #3760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhartnett
changed the title
bhartnett
commented
Oct 10, 2025
| db.txRef = AristoTxRef(db: db, vTop: vTop, snapshot: Snapshot(level: Opt.some(0))) | ||
| db.accLeaves = LruCache[Hash32, AccLeafRef].init(ACC_LRU_SIZE) | ||
| db.stoLeaves = LruCache[Hash32, StoLeafRef].init(ACC_LRU_SIZE) | ||
| db.maxSnapshots = 10 |
Contributor
Author
There was a problem hiding this comment.
This can be made configurable if/when needed.
arnetheduck
reviewed
Nov 3, 2025
| # Checkpoint creates a snapshot of ancestor changes in txFrame - it is an | ||
| # expensive operation, specially when creating a new branch (ie when blk | ||
| # is being applied to a block that is currently not a head). | ||
| parentFrame.checkpoint(blk.header.number, skipSnapshot = false) |
Contributor
Author
There was a problem hiding this comment.
Yes should be txFrame.checkpoint. Will fix in my next PR.
arnetheduck
reviewed
Nov 3, 2025
| # Checkpoint creates a snapshot of ancestor changes in txFrame - it is an | ||
| # expensive operation, specially when creating a new branch (ie when blk | ||
| # is being applied to a block that is currently not a head). | ||
| parentFrame.checkpoint(blk.header.number, skipSnapshot = false) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a snapshots cache/queue to the aristo database instance.
The main purpose of this change is to support limiting the number of snapshots that can be created in total and also to support clearing out old data from snapshots just after persisting.
When we persist a txFrame to the database the base level increases but any snapshots that were not persisted may still have vertexes with a level lower than the base level. This stale data should be removed to further save memory and also prevent issues caused by reading stale data.
If we decided to go ahead with this idea then ideally it should be merged just after this PR: #3737