feat(AppMain): improved banners, section layout, settings shortcut #19670
+166
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
force-pushed
the
feat/banners-sectionlayout-settingsshortcut
branch
from
782584e to
00c176d
Compare
caybro
requested review from
a team,
alexjba,
micieslak and
noeliaSD
as code owners
caybro
commented
Jan 7, 2026
| duration: 500 | ||
| duration: ThemeUtils.AnimationDuration.Slow | ||
| easing.type: Easing.OutCubic | ||
| alwaysRunToEnd: true |
Member
Author
There was a problem hiding this comment.
Do not leave ghost blank space if the animation gets interrupted
caybro
commented
Jan 7, 2026
| } | ||
|
|
||
| // divider | ||
| Rectangle { |
Member
Author
There was a problem hiding this comment.
Internal "divider" between banners
caybro
commented
Jan 7, 2026
| item.hide() | ||
| return | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Updated logic to show banners, based on relevance and/or online status
caybro
commented
Jan 7, 2026
| id: headerBackgroundSlot | ||
| anchors.top: parent.top | ||
| // Needed cause I see a gap otherwise | ||
| anchors.topMargin: -3 |
Member
Author
There was a problem hiding this comment.
Gaps gone but this wasn't the reason :)
Member
Author
There was a problem hiding this comment.
Also noticed @Khushboo-dev-cpp already fixed the gap at the top, thanks 👍
caybro
commented
Jan 7, 2026
| anchors.top: statusToolBar.bottom | ||
| anchors.bottom: footerSlot.top | ||
| anchors.bottomMargin: footerSlot.visible ? 8 : 0 | ||
| anchors.bottomMargin: !!root.footer ? Theme.halfPadding : 0 |
Member
Author
There was a problem hiding this comment.
Only add the space/gap if the footer is present
Member
Jenkins BuildsClick to see older builds (33)
|
caybro
force-pushed
the
feat/banners-sectionlayout-settingsshortcut
branch
from
00c176d to
ea9d292
Compare
- display the banners in appropriate context, and enable them on mobile - if (truly) offline, only display the offline banner (no 3rd party service would work at this point anyway) - fix the blank space that would sometimes be left behind closed banners, and fix the banners spacing (the spacer is moved to inside the banner, otherwise spaces between hidden banners would accumulate and create another blank gap) - fix date/time formatting in the banners - enable the Settings shortcut to work across all relevant sections - some minor fixes & cleanups Fixes #12938 Fixes #18338 Fixes #19298 Fixes #19279
caybro
force-pushed
the
feat/banners-sectionlayout-settingsshortcut
branch
from
ea9d292 to
1159439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Reduces visual clutter with banners
Fixes #12938
Fixes #18338
Fixes #19298
Fixes #19279
Affected areas
AppMain
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
One banner:
No relevant banners:
Gap in the section layout; before:
After:
Impact on end user
Less distracting banners
How to test
Risk
low