feat: add stats/base/ndarray/dnanmskmidrange#10083
feat: add stats/base/ndarray/dnanmskmidrange#10083Sachinn-64 wants to merge 2 commits intostdlib-js:developfrom
stats/base/ndarray/dnanmskmidrange#10083Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/stats/base/ndarray/dnanmskmidrange/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dnanmskmidrange/docs/repl.txt
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/ndarray/dnanmskmidrange/docs/repl.txt
Outdated
Show resolved
Hide resolved
| var xbuf = uniform( 10, -50.0, 50.0, { | ||
| 'dtype': 'float64' | ||
| }); | ||
| var x = new ndarray( xbuf.dtype, xbuf, [ xbuf.length ], [ 1 ], 0, 'row-major' ); |
There was a problem hiding this comment.
This is incorrect. xbuf does not have a .dtype property. Ditto for maskbuf.
There was a problem hiding this comment.
I see this same mistake was made elsewhere in stats/base/ndarray/*. This should be fixed.
There was a problem hiding this comment.
Hey @kgryte, I noticed the same issue in stats/base/ndarray/dnanmskrange. Should I go ahead and fix it?
There was a problem hiding this comment.
Yes, there appear to be several instances of this which all need to be fixed, I believe. So you'll want to do a broader audit.
There was a problem hiding this comment.
Understood. I’ll search for all similar occurrences across the codebase and address them in a single PR.
There was a problem hiding this comment.
@kgryte I performed a broader audit across the codebase for this inconsistency, and it seems to be present only in stats/base/ndarray/dnanmskrange
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves None.
Description
This pull request:
stats/base/ndarray/dnanmskmidrangeRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers