Skip to content

chore: fix JavaScript lint errors (issue #10693)#10694

Open
parthodas23 wants to merge 1 commit intostdlib-js:developfrom
parthodas23:fix/js-lint-errors-10693
Open

chore: fix JavaScript lint errors (issue #10693)#10694
parthodas23 wants to merge 1 commit intostdlib-js:developfrom
parthodas23:fix/js-lint-errors-10693

Conversation

@parthodas23
Copy link
Contributor

Resolves #10693 .

Description

What is the purpose of this pull request?

This pull request:

  • RangeError Fix: Added a safety check in @stdlib/_tools/github/create-issue to prevent a RangeError: Invalid time value when parsing rate limit reset timestamps.
  • Refactor Nested Functions: Moved get and set methods in @stdlib/nlp/lda to the module scope to comply with stdlib/no-unnecessary-nested-functions and improve memory efficiency.
  • Lint Cleanup: Removed unused eslint-disable directives in @stdlib/boolean/ctor tests that were triggering errors due to strict reporting.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 4, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 4, 2026

Coverage Report

Package Statements Branches Functions Lines
boolean/ctor $\color{green}103/103$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}0/0$
$\color{green}+100.00%$
$\color{green}103/103$
$\color{green}+100.00%$
nlp/lda $\color{red}461/855$
$\color{green}+53.92%$
$\color{green}18/18$
$\color{green}+100.00%$
$\color{red}1/11$
$\color{green}+9.09%$
$\color{red}461/855$
$\color{green}+53.92%$

The above coverage report was generated for the changes in this PR.

@parthodas23 parthodas23 force-pushed the fix/js-lint-errors-10693 branch from cc516c5 to c4ff190 Compare March 4, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants