Skip to content

Conversation

@hrshya
Copy link
Contributor

@hrshya hrshya commented Jan 6, 2026

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the stats/base/dists/degenerate/* packages.
  • Replaces uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Updates the test messages to follow code conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 6, 2026
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 6, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/degenerate/cdf $\color{green}261/261$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}261/261$
$\color{green}+0.00%$
stats/base/dists/degenerate/ctor $\color{green}495/495$
$\color{green}+0.00%$
$\color{green}30/30$
$\color{green}+0.00%$
$\color{green}17/17$
$\color{green}+0.00%$
$\color{green}495/495$
$\color{green}+0.00%$
stats/base/dists/degenerate/entropy $\color{green}161/161$
$\color{green}+0.00%$
$\color{green}7/7$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}161/161$
$\color{green}+0.00%$
stats/base/dists/degenerate/logcdf $\color{green}247/247$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}247/247$
$\color{green}+0.00%$
stats/base/dists/degenerate/logpdf $\color{green}251/251$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}251/251$
$\color{green}+0.00%$
stats/base/dists/degenerate/mean $\color{green}153/153$
$\color{green}+0.00%$
$\color{green}5/5$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}153/153$
$\color{green}+0.00%$
stats/base/dists/degenerate/median $\color{green}153/153$
$\color{green}+0.00%$
$\color{green}5/5$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}153/153$
$\color{green}+0.00%$
stats/base/dists/degenerate/mgf $\color{green}253/253$
$\color{green}+0.00%$
$\color{green}14/14$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}253/253$
$\color{green}+0.00%$
stats/base/dists/degenerate/mode $\color{green}153/153$
$\color{green}+0.00%$
$\color{green}5/5$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}153/153$
$\color{green}+0.00%$
stats/base/dists/degenerate/pdf $\color{green}249/249$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}249/249$
$\color{green}+0.00%$
stats/base/dists/degenerate/pmf $\color{green}247/247$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}247/247$
$\color{green}+0.00%$
stats/base/dists/degenerate/quantile $\color{green}266/266$
$\color{green}+0.00%$
$\color{green}18/18$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}266/266$
$\color{green}+0.00%$
stats/base/dists/degenerate/stdev $\color{green}153/153$
$\color{green}+0.00%$
$\color{green}7/7$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}153/153$
$\color{green}+0.00%$
stats/base/dists/degenerate/variance $\color{green}161/161$
$\color{green}+0.00%$
$\color{green}7/7$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}161/161$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

hrshya added 2 commits January 6, 2026 20:09
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 7, 2026
@stdlib-bot
Copy link
Contributor

PR Commit Message

bench: update random value generation

PR-URL: https://github.com/stdlib-js/stdlib/pull/9589

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 75552e8 into stdlib-js:develop Jan 7, 2026
30 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants