Skip to content

fix: multiple improvements including Gmail label collision fix, docs tabs, and date parsing#139

Open
salmonumbrella wants to merge 7 commits intosteipete:mainfrom
salmonumbrella:fix/issue-137-label-create
Open

fix: multiple improvements including Gmail label collision fix, docs tabs, and date parsing#139
salmonumbrella wants to merge 7 commits intosteipete:mainfrom
salmonumbrella:fix/issue-137-label-create

Conversation

@salmonumbrella
Copy link
Contributor

@salmonumbrella salmonumbrella commented Jan 29, 2026

Summary

  • fix(gmail): Avoid label ID collisions on create by adding preflight check and improved error handling
  • fix(calendar): Prevent Kong from splitting BYDAY recurrence rules
  • feat(docs): Add comprehensive tab management commands (list, add, update, delete) and batch edit support
  • feat(cli): Improve relative time parsing with support for weekdays, durations, and named days
  • refactor(cli): Consolidate date helpers and add sentinel errors for better error handling
  • fix(docs): Resolve variable shadowing lint errors
  • fix(gmail): Include cc/bcc headers in get output

Closes

Test Plan

  • All existing tests pass (go test ./...)
  • New tests added for Gmail label collision detection
  • New tests added for docs tabs commands
  • New tests added for relative time parsing
  • Calendar recurrence rule tests verify BYDAY not split
  • Gmail get output includes cc/bcc headers

🤖 Generated with Claude Code

salmonumbrella and others added 7 commits January 27, 2026 12:15
Kong's default []string behavior splits on commas, which corrupted
recurrence rules with BYDAY parameters like "MO,TU,WE,TH,FR".

Added `sep:"none"` tag to Recurrence fields in:
- CalendarCreateCmd
- CalendarUpdateCmd
- CalendarFocusTimeCmd

This disables comma-splitting while preserving the ability to pass
multiple --rrule flags.

Also improved help text for CalendarFocusTimeCmd to include an example.

Fixes steipete#120

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Export StartOfDay and ParseWeekday from cli package
- Remove duplicate implementations from cmd/time_helpers.go
- Add sentinel errors (ErrEmptyTimeExpression, ErrInvalidTimeFormat, etc.)
- Remove unused endOfDay function from dates.go
- Fix whitespace and import formatting per linter

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use explicit var declarations and assignment operators to avoid
shadowing the outer err variable in DocsUpdateCmd.Run switch cases.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@yousefamar
Copy link

What's blocking this merge? Anything I can help with?

itsjeremyjohnson added a commit to Robben-Media/gogcli that referenced this pull request Feb 16, 2026
…date parsing

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
itsjeremyjohnson added a commit to Robben-Media/gogcli that referenced this pull request Feb 16, 2026
Merged DocsWriteCmd from PR steipete#146 with existing DocsUpdateCmd from PR steipete#139.
Removed PR steipete#146's simpler DocsUpdateCmd to avoid duplicate type definition.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants