feat(calendar): add --send-updates flag to update command#177
Closed
ejc3 wants to merge 1 commit intosteipete:mainfrom
Closed
feat(calendar): add --send-updates flag to update command#177ejc3 wants to merge 1 commit intosteipete:mainfrom
ejc3 wants to merge 1 commit intosteipete:mainfrom
Conversation
Adds the --send-updates flag to 'gog calendar update' to allow sending email notifications to attendees when updating calendar events. The flag supports the same values as the create command: - all: Notifications sent to all guests (default) - externalOnly: Notifications sent to non-Google Calendar guests only - none: No notifications sent This matches the Google Calendar API's sendUpdates parameter for the events.patch endpoint. Closes #601 (if that issue exists for this feature request)
ejc3
force-pushed
the
add-send-updates-to-calendar-update
branch
from
93a0936 to
74857f5
Compare
Owner
|
Closing as already landed. is on now, with tests and docs, via the work tracked in #163. This PR's behavior is already present in current and README/changelog coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
--send-updatesflag togog calendar updateto allow sending email notifications to attendees when updating calendar events.Changes
SendUpdatesfield toCalendarUpdateCmdstructRunmethod to validate and pass thesendUpdatesparameter to the APIFlag Values
The flag supports the same values as the create command:
all: Notifications sent to all guests (default when specified)externalOnly: Notifications sent to non-Google Calendar guests onlynone: No notifications sentExample Usage
Testing
TestCalendarUpdateCmd_SendUpdates- verifies--send-updates=allTestCalendarUpdateCmd_SendUpdatesExternalOnly- verifies--send-updates=externalOnlyRelated
Closes #190 (partial - this PR addresses the update command; issue #50 addressed the create command)